route directive: ignore empty header values#753
Merged
istio-testing merged 1 commit intoistio:release-1.1from Jan 10, 2019
Merged
route directive: ignore empty header values#753istio-testing merged 1 commit intoistio:release-1.1from
istio-testing merged 1 commit intoistio:release-1.1from
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
douglas-reid
left a comment
There was a problem hiding this comment.
/lgtm
So, if you want to "zero out" a header, the right way is to REMOVE, and not to set to "", correct ?
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, kyessenov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
@douglas-reid Yes. I don't think there is no good use case for setting an empty header, so no useful case is eliminated with this change. |
yangminzhu
pushed a commit
to yangminzhu/api
that referenced
this pull request
Jan 15, 2019
Signed-off-by: Kuat Yessenov <kuat@google.com>
louiscryan
pushed a commit
to louiscryan/api
that referenced
this pull request
Jan 16, 2019
Signed-off-by: Kuat Yessenov <kuat@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per istio/istio#10801, empty header values are rarely desirable. We can use the empty value as a special conditional value.
/assign @geeknoid
Signed-off-by: Kuat Yessenov kuat@google.com