rename NetworkScope to ServiceDependency#720
Merged
rshriram merged 2 commits intoistio:release-1.1from Nov 29, 2018
Merged
Conversation
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ZackButcher
approved these changes
Nov 29, 2018
Contributor
ZackButcher
left a comment
There was a problem hiding this comment.
Looks good to me. /cc @louiscryan
Contributor
|
Why ?
…On Wed, Nov 28, 2018, 19:17 Shriram Rajagopalan ***@***.*** wrote:
Signed-off-by: Shriram Rajagopalan ***@***.***
------------------------------
You can view, comment on, or merge this pull request online at:
#720
Commit Summary
- rename NetworkScope to ServiceDependency
File Changes
- *M* mesh/v1alpha1/config.pb.go
<https://github.com/istio/api/pull/720/files#diff-0> (251)
- *M* mesh/v1alpha1/config.proto
<https://github.com/istio/api/pull/720/files#diff-1> (22)
- *M* mesh/v1alpha1/istio.mesh.v1alpha1.pb.html
<https://github.com/istio/api/pull/720/files#diff-2> (38)
- *M* networking/v1alpha3/destination_rule.pb.go
<https://github.com/istio/api/pull/720/files#diff-3> (184)
- *M* networking/v1alpha3/destination_rule.proto
<https://github.com/istio/api/pull/720/files#diff-4> (2)
- *M* networking/v1alpha3/istio.networking.v1alpha3.pb.html
<https://github.com/istio/api/pull/720/files#diff-5> (362)
- *R* networking/v1alpha3/service_dependency.pb.go
<https://github.com/istio/api/pull/720/files#diff-6> (285)
- *R* networking/v1alpha3/service_dependency.proto
<https://github.com/istio/api/pull/720/files#diff-7> (38)
- *M* networking/v1alpha3/service_entry.pb.go
<https://github.com/istio/api/pull/720/files#diff-8> (68)
- *M* networking/v1alpha3/service_entry.proto
<https://github.com/istio/api/pull/720/files#diff-9> (2)
- *M* networking/v1alpha3/virtual_service.pb.go
<https://github.com/istio/api/pull/720/files#diff-10> (228)
- *M* networking/v1alpha3/virtual_service.proto
<https://github.com/istio/api/pull/720/files#diff-11> (3)
- *M* proto.lock <https://github.com/istio/api/pull/720/files#diff-12>
(12)
- *M* python/istio_api/mesh/v1alpha1/config_pb2.py
<https://github.com/istio/api/pull/720/files#diff-13> (74)
- *M* python/istio_api/networking/v1alpha3/destination_rule_pb2.py
<https://github.com/istio/api/pull/720/files#diff-14> (72)
- *A* python/istio_api/networking/v1alpha3/service_dependency_pb2.py
<https://github.com/istio/api/pull/720/files#diff-15> (241)
- *M* python/istio_api/networking/v1alpha3/service_entry_pb2.py
<https://github.com/istio/api/pull/720/files#diff-16> (32)
- *M* python/istio_api/networking/v1alpha3/virtual_service_pb2.py
<https://github.com/istio/api/pull/720/files#diff-17> (140)
Patch Links:
- https://github.com/istio/api/pull/720.patch
- https://github.com/istio/api/pull/720.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#720>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFI6nj-VaVAK3uHJZWjRfB_009kzR27ks5uz1HRgaJpZM4Y43BE>
.
|
Member
|
co-ask... is it for differentiating with k8s network policy or others? |
Member
|
Yes. I talked with @rshriram on slack. He meant not to make user confused with k8s network policy. |
Member
|
How about ServiceScope? @rshriram @costinm @hzxuzhonghu @louiscryan service dependency feels a little odd to me. |
Contributor
|
I think we agreed on network scope.
…On Thu, Nov 29, 2018, 08:38 Lin Sun ***@***.*** wrote:
How about ServiceScope? @rshriram <https://github.com/rshriram> @costinm
<https://github.com/costinm> @hzxuzhonghu <https://github.com/hzxuzhonghu>
@louiscryan <https://github.com/louiscryan>
service dependency feels a little odd to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#720 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFI6mfE0U5eTMCyfa5R_boLbCLs2Yflks5u0A2HgaJpZM4Y43BE>
.
|
Member
Author
|
@costinm this was after talking to @louiscryan . you might want to sync with him on all the happenings in this area over the last couple of days |
Contributor
|
Afaik there are several discussions and options - but no final decision
yet, and we have processes for this kind of stuff.
…On Thu, Nov 29, 2018, 18:32 Shriram Rajagopalan ***@***.*** wrote:
@costinm <https://github.com/costinm> this was after talking to
@louiscryan <https://github.com/louiscryan> . you might want to sync with
him on all the happenings in this area over the last couple of days
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#720 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFI6v2a8AP4V_udv1TeL_dQ5Bm2inW7ks5u0JjQgaJpZM4Y43BE>
.
|
Contributor
|
So far we have clear consensus on moving forward with ns isolation - not on
actual syntax or naming for deps, or how it relates with the existing use
of ServiceEntry for defining dependencies.
My proposal is to hold on this new CRD - and for 1.1 just reuse the
ServiceEntry mechanism to declare deps on external hosts. We may expand
Gateway as well, but at least not confuse things with a new resource that
overlaps with both until we have a good plan.
…On Thu, Nov 29, 2018, 19:27 Costin Manolache ***@***.*** wrote:
Afaik there are several discussions and options - but no final decision
yet, and we have processes for this kind of stuff.
On Thu, Nov 29, 2018, 18:32 Shriram Rajagopalan ***@***.***
wrote:
> @costinm <https://github.com/costinm> this was after talking to
> @louiscryan <https://github.com/louiscryan> . you might want to sync
> with him on all the happenings in this area over the last couple of days
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#720 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAFI6v2a8AP4V_udv1TeL_dQ5Bm2inW7ks5u0JjQgaJpZM4Y43BE>
> .
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com