Revert "add rbac attributes to mixer global dict (#608)"#611
Merged
istio-testing merged 1 commit intomasterfrom Aug 16, 2018
Merged
Revert "add rbac attributes to mixer global dict (#608)"#611istio-testing merged 1 commit intomasterfrom
istio-testing merged 1 commit intomasterfrom
Conversation
This reverts commit 23363e8.
Contributor
|
Ouch, that didn't cross my mind. Sorry about that.
…On Wed, Aug 15, 2018 at 4:14 PM mandarjog ***@***.***> wrote:
Reverts istio/api#608 <#608>
re-ordering of dictionary elements in not allowed.
Please append to the end.
@geeknoid <https://github.com/geeknoid>
------------------------------
You can view, comment on, or merge this pull request online at:
#611
Commit Summary
- Revert "add rbac attributes to mixer global dict (#608)"
File Changes
- *M* mixer/v1/global_dictionary.yaml
<https://github.com/istio/api/pull/611/files#diff-0> (4)
Patch Links:
- https://github.com/istio/api/pull/611.patch
- https://github.com/istio/api/pull/611.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#611>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVucHbC0uf5U7yl-hxrUMGpmr1SF-xixks5uRKtagaJpZM4V-9DB>
.
|
Contributor
Author
|
np, That's why we need a build gate here! |
Contributor
Author
|
/lgtm |
Collaborator
|
@mandarjog: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandarjog, quanjielin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #608
re-ordering of dictionary elements in not allowed.
Please append to the end.
@geeknoid