Merged
Conversation
Contributor
Author
diemtvu
approved these changes
May 3, 2018
Contributor
|
/hold |
Contributor
Author
|
@geeknoid , can you help to review ? |
geeknoid
approved these changes
May 29, 2018
Contributor
|
Subset is useful if we want to support authN policy on subset of proxies inside mesh(I have a prototype PR for this); if we want to support that, we may have to hold this PR. |
Contributor
Author
|
@diemtvu , do we want to support auth policy on subset as @quanjielin mentioned? |
Contributor
Author
|
Chatted with Quanjie and Diem offline, we are good for this PR to be merged. @geeknoid , the presubmit takes quite a long time, do you know what happens or can you help to merge? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.