Skip to content

Zarr LUTs v2#960

Merged
pgbrodrick merged 17 commits into
isofit:rte_refactorfrom
jammont:rte_ref/luts
May 19, 2026
Merged

Zarr LUTs v2#960
pgbrodrick merged 17 commits into
isofit:rte_refactorfrom
jammont:rte_ref/luts

Conversation

@jammont

@jammont jammont commented May 12, 2026

Copy link
Copy Markdown
Collaborator

Porting #787 to RTE Refactor

@jammont jammont marked this pull request as ready for review May 15, 2026 03:36
@jammont

jammont commented May 15, 2026

Copy link
Copy Markdown
Collaborator Author

A small diagram to show the inheritance structure and a few of the functions owned by each class.
image
ForwardModel initializes an engine:

AtmoEngine inits, supers() -> Atmo inits, supers() -> Reader inits, if no prebuilt calls Writer.write(), reader loads lut -> Atmo postprocesses lut specific to its needs -> done

@jammont

jammont commented May 15, 2026

Copy link
Copy Markdown
Collaborator Author

Could benefit from some extra eyes on the examples errors. I can reproduce it locally, sorta -- the bug seemingly has no rhyme or reason to which test cases it occurs on. Sometimes all tests pass, sometimes one fails, sometimes multiple fail.

@evan-greenbrg

Copy link
Copy Markdown
Collaborator

Could benefit from some extra eyes on the examples errors. I can reproduce it locally, sorta -- the bug seemingly has no rhyme or reason to which test cases it occurs on. Sometimes all tests pass, sometimes one fails, sometimes multiple fail.

I've seen
ValueError: operands could not be broadcast together with shapes (861,) (246,)

Would need to trace the fix fully, but in

L_up = Ls * transup

Ls is at engine resolution and transup is at instrument resolution.

Comment thread isofit/luts/writer.py
@github-actions

Copy link
Copy Markdown
📊 Generated results:

URL: isofit/isofit-test-results#31
SHA: de6fe0c

@pgbrodrick pgbrodrick merged commit 3dba7dc into isofit:rte_refactor May 19, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants