Zarr LUTs#787
Closed
jammont wants to merge 74 commits into
Closed
Conversation
Collaborator
Author
|
There are presently two versions of the zarr implementation:
The first worked well, the second had some issues with fill values. Zarr by default sets the fill value of an array to 0, whereas xarray sets it to |
Collaborator
Author
…r zarr or netcdf; removed force options
Merged
Collaborator
Author
|
Closing as this has been integrated separately in ISOFIT v4.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Implements the ability to create Zarr stores instead of NetCDF when creating a LUT.
Createclass was generalized to be subclassable, introducing:CreateNetCDFcurrent implementationCreateZarrnew Zarr-focused versionxarrayheavily but we could look into using thezarrpackage itself, optionallyluts.createis the primary entry point to determine which Create class to returnluts.loadupdated to detect zarrSome further testing of the efficiency of the xarray implementation is still needed. At the moment, when
flushis called, each variable for each point in the queued points is written to disk consecutively. This may be fine because I target the specific region in the Zarr store to write to for each, but this needs to be tested on larger luts.