RTE refactor#955
Conversation
Redefine RT Engine config to always be dict (no longer list) Initialize new rt engine setup Initialize new rt engine setup Comment out ThermalIR test that will need to be reworked in the future Correct to single engine in multipart check Correct typo to config order which is forward_model, radiative_transfer, then engine Mark skip for IR pytest and reduce redundancy in radiative_transfer.py
Simplify to single RTE per run
Backwards Compatibility for Configs
very broken function moves
move directory structure
add luts.py back in
Refactor forward model inverse
Refactor of forward.py.
|
Seeing fairly noteable discrepancies in one-to-one tests with 3.x dev, looking for causes: 
|
|
Seeing fairly noteable discrepancies in one-to-one tests with 3.x dev, looking for causes: |
|
📊 Generated results:
URL: isofit/isofit-test-results#32 |
|
Good news! This gives the same result as the above (IE, the new lut piece was seemeless) - still seems like we have an issue with externally provided wavelength files to hunt down though. |
|
More good news! Results from running an EnMAP scene (both per pixel and AOE) look pretty decent. Per pixel: AOE: |
Updated to atmosphere in test_pasadena_topoflux
Necessary docs updates to accompany Isofit 4
|
Here are my suite of 1:1 comparisons from basic 6c Apply OE runs. Summary: Some small deltas driven by differences in H2O lookup grids and atmospheric solutions. Reflectance: 
Across the cliff: 
Atmosphere: 
|
|
@evan-greenbrg Thanks! Overall, looking pretty good. Any idea what happened to the refactor AOD retrieval? I don't see any variation in values in the plot... |
@unbohn The apparent lack of variation is a function of the color stretch. Same figure without color stretch: 
However, I'm not quite sure why the AOD is considerably more consistent. It does look a bit locked to the prior, but the prior variance should be the same between runs. |
wavelength calibration patch transfer
Small patch to surface reflectance statevector names.
|
Thanks to the whole team for this major effort! Merging now for preparing the EARSeL tutorial v4.0.0 pre release. |
Draft refactor for tracking overall diff.