universal lut cleanup#921
Conversation
jammont
left a comment
There was a problem hiding this comment.
Looks good, just some comments on the config checks but otherwise looks to resolve the prebuilt-lut issue with apply_oe. Thanks!
| ) | ||
| if np.unique(item).size < len(item): | ||
| errors.append(f"Detected duplicate values in lut_grid item {key}") | ||
| if "interp" not in item: |
There was a problem hiding this comment.
interp shouldn't be a key of lut_grid, iirc. lut_grid is just that, the lut grid, while lut_names is the lut loading strategy, eg. lut_names: {dim: {"interp": val}, ...}
There was a problem hiding this comment.
@jammont , I think you're off by a level - you're description above of lut_names is right. But what you have labeled as 'dim' is 'item', and I'm checking if 'interp' is in item.
We're definitely hitting this, as it was thrown as an error.
731abe0 to
655a1fa
Compare
|
📊 Generated results:
URL: isofit/isofit-test-results#19 |
|
@evan-greenbrg - I haven't tested yet, but can you see if the logic flow above (with respect to using statevector priors) matches what you'd hope it would look like in template_construction.py? |
|
I like building the A quick plug for the issue I was seeing when putting together #848, was that the |
|
Yeah - can't promise that every pathway is covered, but that error is what I've tried to address in the config.py and radiative_transfer_config.py updates. |
cdb8f30 to
3c48f5e
Compare
Cleanup to support a large prebuilt lut grid: