Use sRTMnet as the default RT engine#848
Conversation
53987a1 to
bbbd9f4
Compare
|
|
||
| if engine_name == "modtran" and not modtran_path: | ||
| modtran_path = os.getenv("MODTRAN_DIR", env.modtran) | ||
|
|
There was a problem hiding this comment.
@evan-greenbrg I think the easiest way to fold in #833 would be to add a check here for "libradtran" and default to LIBRADTRAN_DIR. that way I don't have to change any conflicting flags/etc in my PR?
a6843ee to
656a378
Compare
| # This becomes more complicated with backward compatability | ||
| # TODO Could abstract this into template construction | ||
| # TODO collapse modtran - emulator paths into single engine path when we eliminate list-based rt_engines | ||
| if engine_name == "sRTMnet" and not emulator_base: |
There was a problem hiding this comment.
this goes for all here, but do we want to make this check case insensitive by just checking .lower() of the input?
| ) | ||
|
|
||
| if emulator_base is None and prebuilt_lut is None: | ||
| max_water = tmpl.calc_modtran_max_water(paths) |
There was a problem hiding this comment.
This line will raise in error in libRadtran case because it will expect to sort through MODTRAN tp6 files which won't be generated. I think this can be changed instead of checking emulator base (or in addition to), to ensuring engine_name is MODTRAN.
|
Run down the run pathway if we only pass in a lut.nc and don't pass in an Make sure we don't break the run case if we pass in a prebuilt lut with incorrect/mismatching key names. |
Adding emulator_base to paths Debugging paths
e89762d to
ac63115
Compare
|
Some of the issues holding this up are related to #921. I would get that in first, rebase, then merge this. |
|
To be addressed after RT-forward refactor |
Adds an optional
apply_oeargument,engine_name, which defaults to sRTMnet. I tried to maintain existingemulator_base-modtran_pathstructure to maintain backwards compatibility foremulator_baserun configurations. This would change existingmodtran_pathrun configurations, which currently can be run without specifying any paths in theapply_oecall.Decision points:
Key block: