Update minipass#15
Merged
isaacs merged 3 commits intoisaacs:mainfrom Mar 25, 2026
Merged
Conversation
BREAKING CHANGE: engines.node is now ">=16 || 14 >=14.17"
wraithgar
commented
Feb 19, 2026
| f.on('data', d => { | ||
| sawData = true | ||
| t.equal(d, 'foo') | ||
| t.equal(d.toString('utf8'), 'foo') |
Contributor
Author
There was a problem hiding this comment.
Casting here instead of passing encoding to get coverage for the "opts is just the callback" code path.
PR-URL: isaacs#15 Credit: @wraithgar Close: isaacs#15 Reviewed-by: @isaacs
6eedc09 to
d850609
Compare
Owner
|
Ack, oops, published as patch, thinking that the port to TS was the breaking change. Is that going to cause a problem? I'm pretty sure npm is the only user, but I can roll it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change since the minipass it extends had breaking changes.
Engines was also updated to match current minipass