You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
I've been bit by this before when using the Pull Request reviewing feature:
I build up a review with several comments
Someone else submits an approving review before I finish and the PR is merged
I try to submit my review and am presented with a flash message telling me I can't anymore
This sequence of events is understandable, but it is not at all clear how to proceed from there. You are left asking yourself these questions:
Can I navigate away from the page without losing my review comments?
As far as I can tell, you can't. Your review just disappears into the void, which is absolutely infuriating, especially since a logical response to the flash message is to refresh the page to see who else reviewed it and who merged it. Pre-merge your pending review survives such page reloads, why wouldn't it after?
Why can't I capture my review comments elsewhere within GitHub when this happens?
Obviously you can't 'un-merge' the PR, and there are no new commits on the source branch to open an issue or new PR around. Why can't this information be persisted in the form of commit comments instead on the latest commit of the source branch instead, or something similar?
Why should it be this way to begin with?
It's worth questioning the assumption that you shouldn't be able to submit a review on merged PRs in the first place. It's obviously not part of usual review flow, of course, but I don't see it harming or confusing the happy path either.
I've been bit by this before when using the Pull Request reviewing feature:
This sequence of events is understandable, but it is not at all clear how to proceed from there. You are left asking yourself these questions:
Can I navigate away from the page without losing my review comments?
As far as I can tell, you can't. Your review just disappears into the void, which is absolutely infuriating, especially since a logical response to the flash message is to refresh the page to see who else reviewed it and who merged it. Pre-merge your pending review survives such page reloads, why wouldn't it after?
Why can't I capture my review comments elsewhere within GitHub when this happens?
Obviously you can't 'un-merge' the PR, and there are no new commits on the source branch to open an issue or new PR around. Why can't this information be persisted in the form of commit comments instead on the latest commit of the source branch instead, or something similar?
Why should it be this way to begin with?
It's worth questioning the assumption that you shouldn't be able to submit a review on merged PRs in the first place. It's obviously not part of usual review flow, of course, but I don't see it harming or confusing the happy path either.