Adds release/3.0.0-beta2 to docs#5714
Conversation
There was a problem hiding this comment.
🤖 Isaac Lab Review Bot
Summary
This PR adds the release/3.0.0-beta2 branch to the documentation build whitelist and updates the README compatibility table for the upcoming Isaac Lab 3.0.0 Beta 2 release.
Changes Reviewed
.github/workflows/docs.yaml
✅ Regex pattern update looks correct. The SMV_BRANCH_WHITELIST regex ^(main|develop|release/3\.0\.0-beta2)$ properly escapes the dots and will correctly match only the intended branch.
📝 Minor consideration: The comment mentions "most release/ branches are excluded" which is accurate and provides good context for future maintainers.
README.md
✅ Version table entry is consistent with the existing format. The v3.0.0* wildcard pattern and Isaac Sim 6.0 association follows the established convention.
CI Status
- Pre-commit checks: ✅ Passed
- License check: ⏳ Pending
- Build Latest Docs: ⏳ Pending
Most other checks are skipping (expected for documentation-only changes).
Recommendations
- No blocking issues found. This is a straightforward documentation update.
- Once the pending CI jobs complete (especially "Build Latest Docs"), the changes should be ready for merge.
- Consider verifying the version switcher renders correctly after the docs build completes.
Review based on commit 3effbca
Greptile SummaryThis PR adds
Confidence Score: 5/5Safe to merge — changes are confined to a regex whitelist update in the docs workflow and a one-row addition to the README table, neither of which affects runtime code. Both changes are minimal and correct: the regex escaping in SMV_BRANCH_WHITELIST is proper, the new branch name matches the intended release/3.0.0-beta2 branch exactly, and the README row is placed in the right chronological position. No logic, tests, or runtime code is touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Push to branch] --> B{Is deploy branch?}
B -- "main / develop / release/*" --> C[Trigger multi-version build]
B -- other branch --> D[Build current-version docs only]
C --> E{SMV_BRANCH_WHITELIST match?}
E -- "main | develop | release/3.0.0-beta2" --> F[Include in version switcher]
E -- other release/* --> G[Build triggered, but NOT in switcher]
F --> H[Deploy to gh-pages]
G --> H
Reviews (1): Last reviewed commit: "Adds release/3.0.0-beta2 to docs" | Re-trigger Greptile |
# Description Adds new release/3.0.0-beta2 to the docs for the QA cycle. This will be the new release branch as we prepare for the Isaac Lab 3.0.0 Beta 2 release. ## Type of change - Documentation update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
# Description Adds new release/3.0.0-beta2 to the docs for the QA cycle. This will be the new release branch as we prepare for the Isaac Lab 3.0.0 Beta 2 release. ## Type of change - Documentation update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
… fix (#5757) (#5774) # Description Cherry pick two changes from develop: - [Adds release/3.0.0-beta2 to docs ](#5714) #5714 - [Fixes ARM64 docker build issue + re-enables JUnit artifacts (for sidecar service)](#5757) #5757 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - Documentation update ## Checklist - [ ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: myurasov-nv <168484206+myurasov-nv@users.noreply.github.com>
Description
Adds new release/3.0.0-beta2 to the docs for the QA cycle. This will be the new release branch as we prepare for the Isaac Lab 3.0.0 Beta 2 release.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there