Greptile Summary

This PR moves all 7 test_rendering_*.py files out of the round-robin isaaclab_tasks [N/3] shards into two new dedicated CI jobs (test-rendering-correctness for 4 in-kit tests, test-rendering-correctness-kitless for 3 OVRTX kitless tests), following the same TESTS_TO_SKIP + include-files pattern already used by test-curobo, test-skillgen, and test-environments-training.

• New constants RENDERING_CORRECTNESS_TESTS and RENDERING_CORRECTNESS_KITLESS_TESTS are added to test_settings.py and splat into TESTS_TO_SKIP, so conftest.py's existing override logic correctly re-includes them only in the dedicated jobs.
• extra-pip-packages: \"ovrtx\" is removed from all three shard jobs (confirmed safe: remaining shard tests that mention ovrtx either use it only as a preset string or skip the relevant cases with pytest.mark.skip).

Confidence Score: 4/5

The change is safe to merge; the only concern is a stale Sphinx cross-reference in a docstring.

The CI restructuring is mechanically straightforward and mirrors an established pattern used by three other dedicated test jobs. The include-files override of TESTS_TO_SKIP in conftest.py is already well-tested. Removing ovrtx from the shard jobs is verified safe: no non-rendering test in isaaclab_tasks actually imports the package at runtime. The one finding is a docstring that points to tools.conftest._install_ovrtx_optional_dep, a function that does not exist anywhere in the repo.

tools/test_settings.py — the RENDERING_CORRECTNESS_KITLESS_TESTS docstring has a stale function cross-reference.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    B[build] --> S1[isaaclab_tasks shard 1/3\nno ovrtx]
    B --> S2[isaaclab_tasks shard 2/3\nno ovrtx]
    B --> S3[isaaclab_tasks shard 3/3\nno ovrtx]
    B --> RC[test-rendering-correctness\n4 in-kit files\nno extra packages]
    B --> RCK[test-rendering-correctness-kitless\n3 kitless files\nextra-pip: ovrtx]

    subgraph TESTS_TO_SKIP
        direction LR
        T1["test_rendering_cartpole.py\ntest_rendering_dexsuite_kuka.py\ntest_rendering_registered_tasks.py\ntest_rendering_shadow_hand.py"]
        T2["test_rendering_cartpole_kitless.py\ntest_rendering_dexsuite_kuka_kitless.py\ntest_rendering_shadow_hand_kitless.py"]
    end

    S1 -.skips via TESTS_TO_SKIP.-> T1
    S1 -.skips via TESTS_TO_SKIP.-> T2
    RC --include-files overrides skip--> T1
    RCK --include-files overrides skip--> T2

_{Reviews (1): Last reviewed commit: "Move rendering-correctness tests into de..." | Re-trigger Greptile}

Incremental Review (e299c70)

✅ Previous feedback addressed - The stale :func: cross-reference to tools.conftest._install_ovrtx_optional_dep has been removed from the RENDERING_CORRECTNESS_KITLESS_TESTS docstring. The simplified docstring is now accurate and avoids Sphinx warnings.

No new issues found in this iteration. LGTM! 🚀

Bot Review Update (2af4bd9):

✅ Previous concern about the stale docstring reference has been addressed.

New changes in this push look good:

• Docker non-root user migration is well-structured with proper CI verification jobs
• Frame stacking observation term (stacked_image) includes comprehensive tests
• Pink IK test fixes and tolerance adjustments are reasonable
• Documentation updates for XR performance are helpful

No new issues identified.

🔄 Incremental Review Update (commit 3fb23dd)

Reviewed changes since previously reviewed commit (2af4bd9).

Previous Concerns

✅ Docstring reference fixed: The stale :func: cross-reference to tools.conftest._install_ovrtx_optional_dep in tools/test_settings.py has been corrected — the new docstring no longer contains the invalid reference.

New Changes Summary

The incremental changes continue the consistent refactoring patterns already present in the PR:

• Import path updates (from isaaclab.utils import configclass → from isaaclab.utils.configclass import configclass)
• Renderer updates to accept ProxyArray instead of torch.Tensor
• Test assertion updates to use warp dtypes (wp.uint8, wp.float32) matching the new warp-backed storage

Assessment

No new issues found. The incremental changes are consistent with the PR's refactoring goals.