Adds mock interfaces selection API.#4722
Merged
AntoineRichard merged 4 commits intoFeb 27, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR introduces a comprehensive mock interface selection API that enables unit testing across different physics backends (PhysX and Newton) without requiring a full simulation environment. Key Changes:
Integration Points: The validation methods are now called throughout PhysX and Newton articulation implementations, providing runtime verification of input shapes and dtypes for all write methods. This catches common errors early during development while maintaining zero overhead in production builds. Confidence Score: 5/5
Important Files Changed
Class Diagram%%{init: {'theme': 'neutral'}}%%
classDiagram
class AssetBase {
+assert_shape_and_dtype()
+assert_shape_and_dtype_mask()
}
class BaseArticulation {
+write_joint_positions()
+write_root_pose()
+find_joints()
}
class BaseRigidObject {
+write_root_pose()
+set_masses()
}
AssetBase <|-- BaseArticulation
AssetBase <|-- BaseRigidObject
class PhysXArticulation {
+_articulation_view
+assert calls in write methods
}
class NewtonArticulation {
+_articulation_view
+assert calls in write methods
}
BaseArticulation <|-- PhysXArticulation
BaseArticulation <|-- NewtonArticulation
class MockArticulationView~PhysX~ {
+get_root_transforms()
+set_mock_root_transforms()
+set_random_mock_data()
}
class MockNewtonArticulationView {
+get_root_transforms()
+get_attribute()
+set_attribute()
}
PhysXArticulation o-- MockArticulationView~PhysX~
NewtonArticulation o-- MockNewtonArticulationView
class FactoryFunctions {
+create_mock_articulation_view()
+create_mock_quadruped_view()
+create_mock_humanoid_view()
}
FactoryFunctions ..> MockNewtonArticulationView : creates
Last reviewed commit: 632e8a2 |
kellyguo11
approved these changes
Feb 26, 2026
Contributor
|
can you help rebase this one? |
ff09671 to
d72572b
Compare
7bfca40 to
233c8e0
Compare
daniela-hase
pushed a commit
to daniela-hase/IsaacLab
that referenced
this pull request
Mar 30, 2026
# Description Adds mock interfaces selection API. Getting the code ready to write UTs across backends. Built ontop of isaac-sim#4720 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds mock interfaces selection API. Getting the code ready to write UTs across backends. Built ontop of #4720
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there