Fixes torch nightly version install in arm system#3464
Conversation
|
|
||
| # read installed torch version (e.g., "2.7.0+cu128"), empty if missing | ||
| local v="" | ||
| if "$py" -m pip show torch >/dev/null 2>&1; then |
There was a problem hiding this comment.
do we need to accommodate for the case where no torch is installed?
There was a problem hiding this comment.
it works fine when Torch isn’t installed. basically no printing of Found PyTorch verison and will execute fresh install in next lines
| @@ -102,37 +102,34 @@ is_arm() { | |||
| } | |||
|
|
|||
| ensure_cuda_torch() { | |||
There was a problem hiding this comment.
General question: Is there a reason why we are enforcing torch CUDA in our install scripts and not via the setup.py?
There was a problem hiding this comment.
Ahh good point
IIRC setup.py's wheel sometime gets a bit unrealible, and had to do more explicit install in bash.
If above point is not true anymore, I think it might be an historical reason?
I was checking the commit history of this file and explicit installation of pytorch is introduced here, 0173252, which seems the intend is to fix the pytorch version docker
The right path forward seems like that we need to ensure we have arm machine running on ci in addition to linux. and whatever changes we make here needs to work on those machine as well. So far I mostly have just been mannually checking if it works in ARM
There was a problem hiding this comment.
ya the setup.py cuda build of torch is very unreliable on windows especially and it will always install the cpu build instead and leads to more errors when we run our workflows :( not sure if uv can do a better job at that though, that might be something we can look into as well.
# Description This PR improves the robustness in detecting arm system and correctly install torch nightly build for cuda130 Fixes # (issue) <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
# Description This PR improves the robustness in detecting arm system and correctly install torch nightly build for cuda130 Fixes # (issue) <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Description
This PR improves the robustness in detecting arm system and correctly install torch nightly build for cuda130
Fixes # (issue)
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there