Skip to content

Adds support for bash history in docker#2659

Merged
kellyguo11 merged 2 commits into
mainfrom
antoiner/docker_history
Jun 17, 2025
Merged

Adds support for bash history in docker#2659
kellyguo11 merged 2 commits into
mainfrom
antoiner/docker_history

Conversation

@AntoineRichard

Copy link
Copy Markdown
Collaborator

Description

Adds support for bash history between docker start/stop cycles.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@AntoineRichard AntoineRichard marked this pull request as ready for review June 10, 2025 19:33
@kellyguo11 kellyguo11 changed the title added support for bash history in docker Adds support for bash history in docker Jun 17, 2025
@kellyguo11 kellyguo11 merged commit 924e1fe into main Jun 17, 2025
4 of 5 checks passed
@kellyguo11 kellyguo11 deleted the antoiner/docker_history branch June 17, 2025 04:14
harry-wf-cheung pushed a commit to harry-wf-cheung/IsaacLab-Harry that referenced this pull request Jul 30, 2025
# Description

Adds support for bash history between docker start/stop cycles.

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
hujc7 added a commit to hujc7/IsaacLab that referenced this pull request May 6, 2026
The Newton 1.2.0rc2 release pulls in two IsaacLab-relevant fixes
(newton-physics/newton#2678, newton-physics/newton#2720 for
SolverKamino reset under world_mask), the upstream tendon-scoping
fix from isaac-sim#2659 ("Scope USD custom-frequency parsing"), and a
VRAM-leak fix on example reset (isaac-sim#2710).

Pin bumps:

* source/isaaclab/setup.py: warp-lang==1.12.0 → >=1.13.0,
  mujoco==3.6.0 → ==3.8.0, mujoco-warp==3.6.0 → ==3.8.0.1.
* source/isaaclab_newton/setup.py: same mujoco / mujoco-warp
  bumps; Newton pin → v1.2.0rc2.
* source/isaaclab_visualizers/setup.py: 3 × Newton pin →
  v1.2.0rc2.
* tools/wheel_builder/res/python_packages.toml: same set of
  pins, mirrored across the wheel-bundling manifest.

Code adapts:

* source/isaaclab_newton/isaaclab_newton/physics/newton_manager.py
  and source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer_kernels.py:
  wp.math.transform_to_matrix → wp.transform_to_matrix. The
  wp.math namespace was removed in warp-lang 1.13.

Smoke verified: Shadow-Hand-Over MAPPO (4 envs, 1 iter) runs
clean on the bumped env — simulation init through CUDA graph
capture through one training step + checkpoint save, no errors.
hujc7 added a commit to hujc7/IsaacLab that referenced this pull request May 6, 2026
The Newton 1.2.0rc2 release pulls in two IsaacLab-relevant fixes
(newton-physics/newton#2678, newton-physics/newton#2720 for
SolverKamino reset under world_mask), the upstream tendon-scoping
fix from isaac-sim#2659 ("Scope USD custom-frequency parsing"), and a
VRAM-leak fix on example reset (isaac-sim#2710).

Pin bumps:

* source/isaaclab/setup.py: warp-lang==1.12.0 → >=1.13.0,
  mujoco==3.6.0 → ==3.8.0, mujoco-warp==3.6.0 → ==3.8.0.1.
* source/isaaclab_newton/setup.py: same mujoco / mujoco-warp
  bumps; Newton pin → v1.2.0rc2.
* source/isaaclab_visualizers/setup.py: 3 × Newton pin →
  v1.2.0rc2.
* tools/wheel_builder/res/python_packages.toml: same set of
  pins, mirrored across the wheel-bundling manifest.

Code adapts:

* source/isaaclab_newton/isaaclab_newton/physics/newton_manager.py
  and source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer_kernels.py:
  wp.math.transform_to_matrix → wp.transform_to_matrix. The
  wp.math namespace was removed in warp-lang 1.13.

Smoke verified: Shadow-Hand-Over MAPPO (4 envs, 1 iter) runs
clean on the bumped env — simulation init through CUDA graph
capture through one training step + checkpoint save, no errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants