Skip to content

finish the SoftwareUpgradeProposal in Gov#55

Merged
wukongcheng merged 2 commits intoirisnet:feature/software-upgradefrom
MrXJC:jiacheng/software-upgrade
Jul 26, 2018
Merged

finish the SoftwareUpgradeProposal in Gov#55
wukongcheng merged 2 commits intoirisnet:feature/software-upgradefrom
MrXJC:jiacheng/software-upgrade

Conversation

@MrXJC
Copy link
Contributor

@MrXJC MrXJC commented Jul 26, 2018

No description provided.

if proposalID !=-1{
keeper.uk.SetCurrentProposalID(proposal.GetProposalID())
} else{
fmt.Println("One SoftwareUpgradeProposal is in process, proposalID = ",proposalID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ... else 逻辑反了

if _,ok := upgradeproposal[title]; ok{
return true
}
return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接return ok

Copy link
Contributor

@wukongcheng wukongcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ... else 逻辑反了

@wukongcheng wukongcheng merged commit 73d1709 into irisnet:feature/software-upgrade Jul 26, 2018
wukongcheng added a commit that referenced this pull request Aug 27, 2018
finish the SoftwareUpgradeProposal in Gov
Nimrostafarian pushed a commit to petri-labs/petrihub that referenced this pull request Jan 3, 2023
wangjiulian pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants