add the Vetos into Version and add the VersionList#51
Merged
wukongcheng merged 4 commits intoirisnet:feature/software-upgradefrom Jul 25, 2018
MrXJC:jiacheng/software-upgrade
Merged
add the Vetos into Version and add the VersionList#51wukongcheng merged 4 commits intoirisnet:feature/software-upgradefrom MrXJC:jiacheng/software-upgrade
wukongcheng merged 4 commits intoirisnet:feature/software-upgradefrom
MrXJC:jiacheng/software-upgrade
Conversation
wukongcheng
reviewed
Jul 25, 2018
modules/upgrade/keeper.go
Outdated
| defaultSwichPeriod int64 = 200 | ||
| ) | ||
|
|
||
| func (k Keeper) SetVersionList(version Version){ |
Contributor
There was a problem hiding this comment.
名字 AddNewVersion 更合理一些
wukongcheng
reviewed
Jul 25, 2018
modules/upgrade/types.go
Outdated
| } | ||
| } | ||
|
|
||
| type ModulesLifeTime []ModuleLifeTime |
Contributor
There was a problem hiding this comment.
这两个名字不仔细看完全一样， ModuleLifeTimeList更清楚些
modules/upgrade/types.go
Outdated
| } | ||
| } | ||
|
|
||
| type ModulesLifeTime []ModuleLifeTime |
Contributor
There was a problem hiding this comment.
这两个名字不仔细看完全一样， ModuleLifeTimeList更清楚些
wukongcheng
reviewed
Jul 25, 2018
modules/upgrade/types.go
Outdated
| type Version struct { | ||
| Id int64 // should be equal with corresponding upgradeProposalID | ||
| Start int64 | ||
| Votes []sdk.AccAddress |
Contributor
There was a problem hiding this comment.
Version里面为什么需要投票列表，这个信息已经在SwitchMsg中了
wukongcheng
reviewed
Jul 25, 2018
modules/upgrade/types.go
Outdated
|
|
||
| type ModuleLifeTimeList []ModuleLifeTime | ||
|
|
||
| func NewModulesLifeTime() ModuleLifeTimeList { |
wukongcheng
suggested changes
Jul 25, 2018
Contributor
wukongcheng
left a comment
There was a problem hiding this comment.
NewModuleLifeTimeList
wukongcheng
approved these changes
Jul 25, 2018
wukongcheng
added a commit
that referenced
this pull request
Aug 27, 2018
add the Vetos into Version and add the VersionList
This was referenced Apr 19, 2024
wangjiulian
pushed a commit
that referenced
this pull request
Nov 7, 2024
* update coinswap grpc query test * update coinswap grpc query test * fix coinswap test * some modigy * update grpc query test * update go.mod * add err check Co-authored-by: 王迪 <wangdi@bianjie.ai> Co-authored-by: Segue <huoda.china@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.