lcd implemenation#256
Merged
wukongcheng merged 29 commits intoirisnet:feature/lcdfrom Sep 19, 2018
HaoyangLiu:feature/lcd-dev-3
Merged
lcd implemenation#256wukongcheng merged 29 commits intoirisnet:feature/lcdfrom HaoyangLiu:feature/lcd-dev-3
wukongcheng merged 29 commits intoirisnet:feature/lcdfrom
HaoyangLiu:feature/lcd-dev-3
Conversation
added 24 commits
September 17, 2018 19:37
Feature/lcd dev 1
IRISHUB-357: go fmt block.go searchtx.go and validatorset.go
IRISHUB-357: fix a bug in assign account number to sequent
…vert coins to main unit in gov cli query
Feature/lcd dev 1
wukongcheng
reviewed
Sep 19, 2018
| signerAddress, err := sdk.AccAddressFromBech32(cliCtx.Signer) | ||
| if err == nil { | ||
| return signerAddress, nil | ||
| } |
Contributor
There was a problem hiding this comment.
if err != nil ? Will it cause the undefined behavior?
wukongcheng
reviewed
Sep 19, 2018
client/context/context.go
Outdated
| Height int64 | ||
| NodeURI string | ||
| FromAddressName string | ||
| Signer string |
Contributor
There was a problem hiding this comment.
Is any docs stating that how many contexts we defined and what 's their use case ?
wukongcheng
reviewed
Sep 19, 2018
client/context/txcontext.go
Outdated
| func (baseTx BaseTx) Validate(cliCtx CLIContext) error { | ||
| if cliCtx.GenerateOnly { | ||
| if len(baseTx.LocalAccountName) == 0 && len(cliCtx.Signer) == 0 { | ||
| return fmt.Errorf("In generate-only mode, either key name or signer address should be specified") |
Contributor
There was a problem hiding this comment.
All these Error should be defined in a errors.go ( as modules/gov/errors.go)
wukongcheng
approved these changes
Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: