Silei/gov: IRISHUB-316：CurrentUpgradeProposalIdParameter refactor#246
Merged
wukongcheng merged 5 commits intoirisnet:feature/govfrom Sep 18, 2018
Merged
Silei/gov: IRISHUB-316：CurrentUpgradeProposalIdParameter refactor#246wukongcheng merged 5 commits intoirisnet:feature/govfrom
wukongcheng merged 5 commits intoirisnet:feature/govfrom
Conversation
MrXJC
reviewed
Sep 18, 2018
modules/parameter/errors.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| DefaultCodespace sdk.CodespaceType = 5 |
Contributor
There was a problem hiding this comment.
I think the DefaultCodespace isn‘t 5. 5 stands for gov. You should use another number.
modules/parameter/errors.go
Outdated
| CodeInvalidMinDepositDenom sdk.CodeType = 101 | ||
| CodeInvalidMinDepositAmount sdk.CodeType = 102 | ||
| CodeInvalidDepositPeriod sdk.CodeType = 103 | ||
| CodeInvalidCurrentUpgradeProposalID sdk.CodeType = 103 |
Contributor
There was a problem hiding this comment.
The codeType of CodeInvalidDepositPeriod and CodeInvalidDepositPeriod is same ? I think they should be different.
| return true | ||
| } | ||
|
|
||
| func (param *CurrentUpgradeProposalIdParam) ToJson() string { |
Contributor
There was a problem hiding this comment.
ToJson and Update is the Govparameter interface.
MrXJC
approved these changes
Sep 18, 2018
wangjiulian
pushed a commit
that referenced
this pull request
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.