[Codegen] Update the assembly formats and corresponding tests for matcher ops#22270
Merged
bangtianliu merged 1 commit intoOct 10, 2025
Merged
Conversation
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
This was referenced Oct 10, 2025
kuhar
approved these changes
Oct 10, 2025
weidel-p
pushed a commit
to weidel-p/iree
that referenced
this pull request
Oct 21, 2025
…cher ops (iree-org#22270) According to this comment: iree-org#22227 (comment), this PR updates the assembly format for contraction and convolution matcher ops. The attention matcher op's indexing map is not optional and also consistent with what is suggested in the comment, so no need to update. Signed-off-by: Bangtian Liu <liubangtian@gmail.com> Signed-off-by: Philipp <philipp.weidel@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this comment: #22227 (comment), this PR updates the assembly format for contraction and convolution matcher ops. The attention matcher op's indexing map is not optional and also consistent with what is suggested in the comment, so no need to update.