Skip to content

Integrate LLVM to llvm/llvm-project@3ed3a33#21364

Merged
bangtianliu merged 5 commits intomainfrom
integrates/llvm-20250714
Jul 15, 2025
Merged

Integrate LLVM to llvm/llvm-project@3ed3a33#21364
bangtianliu merged 5 commits intomainfrom
integrates/llvm-20250714

Conversation

@bangtianliu
Copy link
Contributor

@bangtianliu bangtianliu commented Jul 14, 2025

bump to llvm/llvm-project@3ed3a33

This PR removes "dangling" builders for fixing compatibility issue caused by 2eb733b as similar to PR llvm/llvm-project#147619.

Similarly, this PR also add changes to stablehole: iree-org/stablehlo@7c08581, and add changes to torch-mlir: iree-org/torch-mlir@1983b6d.

Revert llvm/llvm-project@1fdbe69 as it causes failures in IREE's end-to-end matmul tests on the CUDA backend.

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also mention how stablehlo and torch-mlir were updated (SHAs)?

Copy link
Contributor

@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update the playbook. I think it is better to have "Integrate LLVM to llvm/llvm-project@XXX" PR title or at least include the commit hash in the title.

@bangtianliu bangtianliu force-pushed the integrates/llvm-20250714 branch 3 times, most recently from 4b1420e to a50333d Compare July 14, 2025 17:43
@bangtianliu bangtianliu changed the title Integrates/llvm 20250714 Integrate LLVM to llvm/llvm-project@2eb733b Jul 14, 2025
@bangtianliu bangtianliu requested review from hanhanW and kuhar July 14, 2025 19:55
Copy link
Contributor

@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the dangling builders. I wonder if that should belong to the other PR? Is there a reason to land it with the integrate PR toghter?

@bangtianliu
Copy link
Contributor Author

bangtianliu commented Jul 14, 2025

Thanks for removing the dangling builders. I wonder if that should belong to the other PR? Is there a reason to land it with the integrate PR toghter?

Yes, this issue is directly caused by llvm/llvm-project@2eb733b after confirming it with @makslevental(thanks for the help!).

@hanhanW
Copy link
Contributor

hanhanW commented Jul 14, 2025

Thanks for removing the dangling builders. I wonder if that should belong to the other PR? Is there a reason to land it with the integrate PR toghter?

Yes, this issue is directly caused by caused by llvm/llvm-project@2eb733b after confirming it with @makslevental(thanks for the help!).

Then I think you intend to reference the commit in the PR description. It is an upstream fix for the commit now.

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
…en] add concrete create methods (#147168) (Maksim Levental on 2025-07-14 10:41:51 -0400) (28 of 29)

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
@bangtianliu bangtianliu force-pushed the integrates/llvm-20250714 branch from 62c8280 to 0419beb Compare July 14, 2025 21:18
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
@bangtianliu bangtianliu changed the title Integrate LLVM to llvm/llvm-project@2eb733b Integrate LLVM to llvm/llvm-project@40ceaf1 Jul 15, 2025
@bangtianliu bangtianliu changed the title Integrate LLVM to llvm/llvm-project@40ceaf1 Integrate LLVM to llvm/llvm-project@3ed3a33 Jul 15, 2025
@bangtianliu bangtianliu merged commit 6ea822a into main Jul 15, 2025
48 checks passed
@bangtianliu bangtianliu deleted the integrates/llvm-20250714 branch July 15, 2025 06:06
Abhishek-Varma added a commit to nod-ai/iree-amd-aie that referenced this pull request Jul 30, 2025
-- This commit bumps IREE to iree-org/iree@402a9be46a.
-- As part of the same it :-
   a. [removes "dangling" builders](iree-org/iree#21364)
   b. [adds explicit cast](iree-org/iree#21494)
   c. [adds explicit result type of enum](llvm/llvm-project#150308)

Signed-off-by: Abhishek Varma <abhvarma@amd.com>
Abhishek-Varma added a commit to nod-ai/iree-amd-aie that referenced this pull request Aug 5, 2025
-- This commit bumps IREE to iree-org/iree@402a9be46a.
-- As part of the same it :-
   a. [removes "dangling" builders](iree-org/iree#21364)
   b. [adds explicit cast](iree-org/iree#21494)
   c. [adds explicit result type of enum](llvm/llvm-project#150308)

Signed-off-by: Abhishek Varma <abhvarma@amd.com>
Abhishek-Varma added a commit to nod-ai/iree-amd-aie that referenced this pull request Aug 8, 2025
-- This commit bumps IREE to iree-org/iree@402a9be46a.
-- As part of the same it :-
a. [removes "dangling"
builders](iree-org/iree#21364)
   b. [adds explicit cast](iree-org/iree#21494)
c. [adds explicit result type of
enum](llvm/llvm-project#150308)
   d. updates MLIR-AIR to 53e3f44
e. adds `CascadeFlowOp`, `GetCascadeOp` and `PutCascadeOp` to AIE
dialect.

Signed-off-by: Abhishek Varma <abhvarma@amd.com>
AWoloszyn pushed a commit that referenced this pull request Dec 1, 2025
bump to
llvm/llvm-project@3ed3a33

This PR removes "dangling" builders for fixing compatibility issue
caused by
[2eb733b](llvm/llvm-project@2eb733b)
as similar to PR llvm/llvm-project#147619.

Similarly, this PR also add changes to stablehole:
iree-org/stablehlo@7c08581,
and add changes to torch-mlir:
iree-org/torch-mlir@1983b6d.

Revert
llvm/llvm-project@1fdbe69
as it causes failures in IREE's end-to-end matmul tests on the CUDA
backend.

---------

Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants