Fix completions for methods starting with _#15106
Merged
krassowski merged 3 commits intoipython:mainfrom Dec 22, 2025
Merged
Conversation
krassowski
reviewed
Dec 20, 2025
Member
krassowski
left a comment
There was a problem hiding this comment.
The change looks good, should we also have end-to-end test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15104
Description
The current regex pattern only matches attribute access where the attribute name starts with a letter ([a-zA-Z]). This PR modifies the pattern to handle attributes starting with
_too.