Skip to content

TST/DEP: add missing test dependency on setuptools#15040

Closed
neutrinoceros wants to merge 1 commit intoipython:mainfrom
neutrinoceros:tst/setuptools
Closed

TST/DEP: add missing test dependency on setuptools#15040
neutrinoceros wants to merge 1 commit intoipython:mainfrom
neutrinoceros:tst/setuptools

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

setuptools is directly imported in some tests, but not declared as a requirement.
A test env created with, e.g. uv, doesn't include setuptools by default. This fixes it.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

closing in favor of #15041

@neutrinoceros neutrinoceros deleted the tst/setuptools branch October 26, 2025 07:04
Carreau added a commit that referenced this pull request Oct 31, 2025
Include changes from #15040
This is a best-effort attempt to provide/update lower bounds on direct
dependencies in two groups: hard requirements, and test dependencies.
At the time of opening, I still see 7 test failing locally with an env
obtained with `uv sync --resolution=lowest-direct` which may indicate
that some updates are still needed (although it is not clear what
dependencies are causing the failures). It could also be a symptom of
*transitive* dependencies incompatibilities. In any case, this is still
much better than no explicit lower bounds at all.
The end goal is to enable testing downstream with `--resolution=lowest`.
To guide reviewers I've included small comments to justify my choice of
lower bounds. I simply commented "wheel" in places where I picked the
oldest version that has a compatible wheel on PyPI (in some cases, older
versions might still build from source, but relying on much more recent
versions of setuptools is more or less bound to break at some point).

If you're interested, I'd be happy to also setup a CI job to
systematically check that lower bounds are sound and up to date.
@Carreau Carreau added this to the no action milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants