TST/DEP: add missing test dependency on setuptools#15040
Closed
neutrinoceros wants to merge 1 commit intoipython:mainfrom
Closed
TST/DEP: add missing test dependency on setuptools#15040neutrinoceros wants to merge 1 commit intoipython:mainfrom
neutrinoceros wants to merge 1 commit intoipython:mainfrom
Conversation
0e38620 to
752cfcb
Compare
Contributor
Author
|
closing in favor of #15041 |
Carreau
added a commit
that referenced
this pull request
Oct 31, 2025
Include changes from #15040 This is a best-effort attempt to provide/update lower bounds on direct dependencies in two groups: hard requirements, and test dependencies. At the time of opening, I still see 7 test failing locally with an env obtained with `uv sync --resolution=lowest-direct` which may indicate that some updates are still needed (although it is not clear what dependencies are causing the failures). It could also be a symptom of *transitive* dependencies incompatibilities. In any case, this is still much better than no explicit lower bounds at all. The end goal is to enable testing downstream with `--resolution=lowest`. To guide reviewers I've included small comments to justify my choice of lower bounds. I simply commented "wheel" in places where I picked the oldest version that has a compatible wheel on PyPI (in some cases, older versions might still build from source, but relying on much more recent versions of setuptools is more or less bound to break at some point). If you're interested, I'd be happy to also setup a CI job to systematically check that lower bounds are sound and up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setuptools is directly imported in some tests, but not declared as a requirement.
A test env created with, e.g.
uv, doesn't include setuptools by default. This fixes it.