Read script output/error streams as they become available#14695
Merged
Carreau merged 8 commits intoipython:mainfrom Jan 31, 2025
Merged
Read script output/error streams as they become available#14695Carreau merged 8 commits intoipython:mainfrom
Carreau merged 8 commits intoipython:mainfrom
Conversation
Member
Author
|
The test is flaky on Windows, I will rework it.. |
krassowski
commented
Jan 30, 2025
| async def _readchunk(stream): | ||
| try: | ||
| return await stream.readuntil(b"\n") | ||
| return await stream.read(100) |
Member
Author
There was a problem hiding this comment.
This will consume any up to 100 bytes, as soon as at least 1 byte is available. The 100 number is arbitrary, but my hope is it will roughly correspond to an average line length so that it should not change how small/frequent chunks are compared to before (but of course if someone streamed lines of 1000 characters, now those would be returned in 10 chunks instead of 1).
https://docs.python.org/3/library/asyncio-stream.html#asyncio.StreamReader.read
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jan 31, 2025
…ecome available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14648