Fixed bug with a warning message incorrectly displayed#14640
Merged
Carreau merged 1 commit intoipython:mainfrom Jan 11, 2025
Merged
Fixed bug with a warning message incorrectly displayed#14640Carreau merged 1 commit intoipython:mainfrom
Carreau merged 1 commit intoipython:mainfrom
Conversation
`Attempting to work in a virtualenv. If you encounter problems please install IPython inside the virtualenv.` was incorrectly triggered in systems involving symlinks. When the path of VIRTUAL_ENV and the corresponding environment path derived from the executable iPython pointed to the same physical directory, but differ because of symlinks, the warning was triggered. By using `resolve()` function, we ensure that the we compare the fully resolved paths.
Member
|
let's try. I might do a 8.32 with that. Not sure. |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the warning message:
was incorrectly triggered in systems involving symlinks.
When the path provided by
$VIRTUAL_ENVand the corresponding environment path derived from the executable iPython pointed to the same physical directory, but their strings differed because of symlinks, the warning was incorrectly triggered. By using theresolve()function, we ensure that we compare fully resolved paths. The warning disappears when the two folders, once resolved, coincide.