Fix showing SystemExit exception raise inside except handler#14503
Merged
Carreau merged 1 commit intoipython:mainfrom Aug 29, 2024
Merged
Fix showing SystemExit exception raise inside except handler#14503Carreau merged 1 commit intoipython:mainfrom
Carreau merged 1 commit intoipython:mainfrom
Conversation
Member
Author
|
It looks like the failing tests are there on |
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing something like this:
was hitting an error inside UltraTB, creating a long traceback of its internals (which, ironically, UltraTB itself then displays correctly :-).
ListTB.get_exception_only()calls theListTB.structured_traceback()method specifically - even ifselfis a subclass, it won't use the subclass's method. However, the exception chaining in that method uses recursion by callingself.structured_traceback(), which will use a subclass's method. Tuples were added as an option there to support exception chaining, but not all of the machinery in connected classes expects a tuple.This just skips the exception chaining logic for the
etb=Nonecase, when we're showing the exception only. I'm not sure this is necessarily the best fix, but I didn't want to spend too much time following code around a module that's old enough to vote.Closes #12104