Skip to content

Only enable "resume hinting" with right arrow if at the EOL#14052

Merged
Carreau merged 1 commit intoipython:mainfrom
krassowski:fix-right-arrow
May 4, 2023
Merged

Only enable "resume hinting" with right arrow if at the EOL#14052
Carreau merged 1 commit intoipython:mainfrom
krassowski:fix-right-arrow

Conversation

@krassowski
Copy link
Copy Markdown
Member

@krassowski krassowski commented Apr 28, 2023

Fixes #14051

@krassowski krassowski added the bug label Apr 28, 2023
@krassowski krassowski added this to the 8.12.2 milestone Apr 28, 2023
@krassowski krassowski requested a review from Carreau April 28, 2023 12:52
@krassowski krassowski mentioned this pull request Apr 28, 2023
Closed
@2sn
Copy link
Copy Markdown

2sn commented Apr 29, 2023

@krassowski How can I disable this new hinting and right-arrow feature? My apologies, whereas it may look nice, I find it rather unsuitable for practical work.

@krassowski
Copy link
Copy Markdown
Member Author

krassowski commented Apr 29, 2023

What specifically do you find unsuitable for practical work? If this is about #14051 issue, this PR fixes it and I believe @Carreau will look at releasing a bug fix soon. I apologise but there is not much I can do here.

@eirnym
Copy link
Copy Markdown

eirnym commented May 3, 2023 •
edited
Loading

@krassowski This works like a charm and I don't need to disable autosuggestion feature.

Is it possible to do similar binding in general in ipython config?

@krassowski
Copy link
Copy Markdown
Member Author

krassowski commented May 3, 2023

Yes, as outlined in #14051 (comment) and the following comment.

sebcampos
sebcampos reviewed May 3, 2023
View reviewed changes
Copy link
Copy Markdown

@sebcampos sebcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@Carreau Carreau merged commit 78fcf82 into ipython:main May 4, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request May 4, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request May 4, 2023
@Carreau @meeseeksmachine
Backport PR ipython#14052: Only enable "resume hinting" with right ar…
c363cee 
…row if at the EOL
Carreau added a commit that referenced this pull request May 4, 2023
@Carreau
Backport PR #14052 on branch 8.12.x (Only enable "resume hinting" wit…
e90f0a5 
…h right arrow if at the EOL) (#14068)

Backport PR #14052: Only enable "resume hinting" with right arrow if at
the EOL
@eirnym
Copy link
Copy Markdown

eirnym commented May 4, 2023

@krassowski I asked about keybindings in general, not a workaround.

@krassowski
Copy link
Copy Markdown
Member Author

krassowski commented May 4, 2023

Every shortcut can be changed to your liking since #13928, with documented TerminalInteractiveShell.shortcuts traitlet, list of shortcuts.

@EliahKagan EliahKagan mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Carreau Carreau Awaiting requested review from Carreau

1 more reviewer

@sebcampos sebcampos sebcampos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

8.12.2

Development

Successfully merging this pull request may close these issues.

Right arrow broken in 8.12.1

5 participants

@krassowski @2sn @eirnym @sebcampos @Carreau