Tests compatibility with Python 3.10 #12759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Pythons stores annotations as strings and evaluate them later.
New argparse module uses "options" instead "optional arguments". python/cpython@41b223d
Contributor
Author
|
Not sure if I have to fix the tests. On windows, there is an error unrelated to this change: and linter complains about stuff I haven't changed but I can definitely fix if needed. |
hroncok
reviewed
Jan 7, 2021
| pytest.skip(f"Module {module_name} is not available.") | ||
|
|
||
| output = pretty.pretty(getattr(module, "Null")) | ||
| nt.assert_equal(output, 'xxlimited.Null') |
Contributor
There was a problem hiding this comment.
Just a curious ask: This is not 'xxlimited_35.Null' on xxlimited_35, right?
Contributor
Author
|
The change of test_oinspect is no longer needed because the postponed evaluation of type annotations has been postponed. For the rest, I'm gonna use PR #13080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.10.0a4 has some differences and we are already building Python RPM packages with it so I'm bringing here the changes I need to do to make the tests pass with the latest Python 3.10.0a4. Tests still work for me in Python 3.9.
More explained in individual commits.