-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Python 3.10 compatibility #13080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 compatibility #13080
Conversation
|
CI is green but I've realized that we don't have Py 3.10 in CI yet so I'm gonna run the tests with the release candidate locally. |
|
I'm afraid that there is more than one test failing and it seems that the other failures have something to do with jedi which is not compatible with Python 3.10 yet. Will have to investigate it more. |
New argparse module uses "options" instead "optional arguments". python/cpython@41b223d
|
This PR now solves all problems with Python 3.10 I know about. All tests are passing in my local environment with Python 3.10rc1. Also, the full compatibility depends on the similar fix for jedi: davidhalter/jedi#1795 |
|
Thank you so much, @frenzymadness ! Can you also add a |
df19297 to
9b5e705
Compare
|
It seems that the nose is not compatible with Python 3.10. and it's abandoned for quite some time so I don't expect anything. Is there any plan to drop it? We might run pytest first and then iptest/nose. Also, the tests will fail until jedi is fixed. |
Yes, I'm currently trying to get some funding from NF to hire someone to do the bulk of the work. Some modification to ipykernel will be needed too as it import things from IPython that rely on nose. |
I might be able to help with that effort. Could you please tell me more? The ultimate goal is to get rid of the nose entirely and port all the tests to pytest, correct? What is nose used for in runtime? |
|
Most of nose use-case are That's the easy part, there are a bunch of utils, like It's likely portable to pytest, but need some time to actually focus on that. Good news is the test suite is old (20 years or so), and therefore I think that many of the test are not useful anymore, so if some tests can't be ported and need to be removed, it's ok. Also most of the functionality in iptest can be nuked as it pre-date having CI and was dealing with parallelizing the test and stuff like that. I'll open a more specific issue and list all the tasks that need to be done for removing nose a a dependency. |
|
Thanks for the PR, I incorporated your work in #13282 which got merged. |
Fixes #13079
Let's see whether it fixes all the problems or not.