Exclude empty requests data in commitment (EIP-7685)#1094
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
==========================================
+ Coverage 94.18% 94.29% +0.11%
==========================================
Files 159 159
Lines 17316 17319 +3
==========================================
+ Hits 16309 16331 +22
+ Misses 1007 988 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
commented
Jan 8, 2025
313a9d2 to
4085f2e
Compare
Member
|
Just for reference: This PR is required for ethereum/execution-spec-tests#1028 to be able to |
e6daa2f to
c321745
Compare
68cd33c to
bbb0468
Compare
pdobacz
approved these changes
Jan 20, 2025
Member
pdobacz
left a comment
There was a problem hiding this comment.
lgtm, but let's have more eyes on this, I authored parts of this
chfast
added a commit
that referenced
this pull request
Jan 20, 2025
The [pectra-devnet-5 specs] includes an [update to EIP-2935]'s system contract and its address. To pass blockchain tests the #1094 is required, but we are going to merge this change first. [pectra-devnet-5 specs]: https://notes.ethereum.org/@ethpandaops/pectra-devnet-5 [update to EIP-2935]: ethereum/EIPs#9144
Apply the [EIP-7685 update] included in [pectra-devnet-5]. [EIP-7685 update]: ethereum/EIPs#8989 [pectra-devnet-5]: https://notes.ethereum.org/@ethpandaops/pectra-devnet-5
62deda1 to
4b63db6
Compare
gumb0
approved these changes
Jan 20, 2025
4b63db6 to
c9be41e
Compare
c9be41e to
29b7e2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the EIP-7685 update included in pectra-devnet-5.
This requires a fix in tests for calldata repricing logic according to ethereum/EIPs#9227