test: deterministic ipns fixtures during sharness gateway tests#9667
Merged
hacdias merged 12 commits intoipfs:masterfrom May 3, 2023
Merged
test: deterministic ipns fixtures during sharness gateway tests#9667hacdias merged 12 commits intoipfs:masterfrom
hacdias merged 12 commits intoipfs:masterfrom
Conversation
d5e2321 to
4ba4e4b
Compare
laurentsenta
commented
Mar 1, 2023
901a216 to
3dead58
Compare
Member
|
@laurentsenta I can review this after you resolve the conflicts. It is showing a lot of things that you didn't change so it's a bit confusing. |
3dead58 to
7b5054e
Compare
hacdias
approved these changes
Mar 3, 2023
bc972a2 to
727dc79
Compare
This was referenced Mar 10, 2023
d57d1b7 to
e3a4e9f
Compare
Member
|
(moving to draft – seems you've removed all |
d69b8ea to
7d2c516
Compare
ad48cc3 to
784ca30
Compare
14 tasks
9341e07 to
cbb5d40
Compare
Contributor
|
@hacdias : can you please look at this again so we can get it merged? |
hacdias
reviewed
May 2, 2023
Member
hacdias
left a comment
There was a problem hiding this comment.
@laurentsenta I gave it a quick look and it looks good to me. Please take a look at my review in ipfs/boxo#278. Once that is complete, ping me here again.
5672341 to
f9b1ee3
Compare
hacdias
requested changes
May 3, 2023
Member
hacdias
left a comment
There was a problem hiding this comment.
Looks good for me. I merged the companion PR in Boxo. Just need to update Boxo here and I'll approve it. Thanks for all this work @laurentsenta. Excited to see these tests coming to the gateway conformance suite soon.
- prevent error on `ipfs routing put`
f9b1ee3 to
61245c9
Compare
61245c9 to
18c4257
Compare
hacdias
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #9657, closes #9654.
Adds deterministic fixtures with ipns