Thanks for the review @hacdias, I patched your comments,
and I removed the IPNS change for now (it started breaking for no apparent reason). I'll add this in a second PR.

go test is failing at the moment but since we haven't touched code other than sharness shell scripts, I guess this is unrelated flakiness.

I re-run the go test in GitHub and it's fine now. There are a few flaky tests and they seem to fail more often in GitHub Actions than Circle CI actually.

I checked success ratios of go-test in the last 24 hours. It's 29% for CircleCI and 29.4% for GitHub Actions. CircleCI can't do fractions so it seems to be the same thing. I didn't go further than 24 hours because we only started collecting GitHub Actions data 3 days ago and CircleCI only offers insights in 1, 7, 30, 60, 90 day intervals.

interop is the only test that seems to be doing worse on GHA. 92% vs 73.3%. Luckily, it's only on the surface. CircleCI cheats here a bit because it doesn't count cases where build failed and interop couldn't even start; like this one https://github.com/ipfs/kubo/pull/9677/checks?check_run_id=11653777666.

Overall, it seems we're pretty much on track to be able to disable CircleCI. I'll dig into the data more before the final cleanup PR but there's nothing worrying standing out.

Here's the WIP GHA monitoring dashboard if you want a peek: https://protocollabs.grafana.net/d/gieYOhbVk/github-actions-ipfs-kubo?orgId=1&from=now-3d&to=now (cc @BigLep since I think you might be interested ;)

@galargh interesting. My "it seems" is just based on my observations on my PRs specifically, so I might just be unlucky :P Thanks for the link!