Merged
Conversation
marten-seemann
approved these changes
Sep 20, 2022
This was referenced Sep 21, 2022
Closed
Contributor
|
Exposing WebTransport functionality is tracked in #9289 |
7ca1d7c to
d20b61c
Compare
Jorropo
commented
Sep 21, 2022
c4f2a45 to
2572f00
Compare
Jorropo
commented
Sep 21, 2022
| go_cgo_go_to_c_calls_calls_total | ||
| go_gc_cycles_automatic_gc_cycles_total | ||
| go_gc_cycles_forced_gc_cycles_total | ||
| go_gc_cycles_total_gc_cycles_total |
Contributor
Author
There was a problem hiding this comment.
We can't configure thoses sadly because they are already registered at init by the lib:
https://github.com/prometheus/client_golang/blob/9801a4e3ceb49d24dfaf4fa6fc8c2d58aa3b2dc9/prometheus/registry.go#L61-L64
(so if we try to do so it just panic)
Member
There was a problem hiding this comment.
@Jorropo oof, is this upstream issue?
We are handling this gracefully for our own metrics: https://github.com/ipfs/kubo/blob/v0.16.0/core/corehttp/gateway_handler.go#L181-L187
fdb6ace to
a58ba55
Compare
This does not include any WebTransport config code in Kubo, this will be done later in an other PR.
a58ba55 to
fb22320
Compare
marten-seemann
approved these changes
Sep 21, 2022
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
chore: bump go-libp2p v0.23.1 This commit was moved from ipfs/kubo@5bcbd15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not include any WebTransport config code in Kubo, this will be done later in an other PR.