feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set#8559
Merged
lidel merged 3 commits intoupdate-libp2pfrom Nov 23, 2021
Merged
feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set#8559lidel merged 3 commits intoupdate-libp2pfrom
lidel merged 3 commits intoupdate-libp2pfrom
Conversation
vyzo
approved these changes
Nov 19, 2021
lidel
requested changes
Nov 19, 2021
Member
lidel
left a comment
There was a problem hiding this comment.
LGTM, but I would clarify how to enable RelayV1 in relayd (its disabled right now) and do the hard stop when EnableRelayHop:true
5a3963f to
e9d7c86
Compare
lidel
approved these changes
Nov 23, 2021
Member
lidel
left a comment
There was a problem hiding this comment.
Thanks, lgtm.
While not ideal, this provides existing users of v1 with an actionable path to move forward if they need to continue running v1 in their infra.
585aa67 to
49a78be
Compare
lidel
approved these changes
Nov 23, 2021
lidel
added a commit
that referenced
this pull request
Nov 23, 2021
…8559) * exit when Swarm.EnableRelayHop is set * chore: go-ipfs-config v0.18.0 Co-authored-by: Marcin Rataj <lidel@lidel.org>
aschmahmann
added a commit
that referenced
this pull request
Nov 29, 2021
…xts (#8563) * plumb through go-datastore context changes * update go-libp2p to v0.16.0 * use LIBP2P_TCP_REUSEPORT instead of IPFS_REUSEPORT * use relay config * making deprecation notice match the go-ipfs-config key * docs(config): circuit relay v2 * docs(config): fix links and headers * feat(config): Internal.Libp2pForceReachability This switches to config that supports setting and reading Internal.Libp2pForceReachability OptionalString flag * use configuration option for static relays * chore: go-ipfs-config v0.18.0 https://github.com/ipfs/go-ipfs-config/releases/tag/v0.18.0 * feat: circuit v1 migration prompt when Swarm.EnableRelayHop is set (#8559) * exit when Swarm.EnableRelayHop is set * docs: Experimental.ShardingEnabled migration This ensures existing users of global sharding experiment get notified that the flag no longer works + that autosharding happens automatically. For people who NEED to keep the old behavior (eg. have no time to migrate today) there is a note about restoring it with `UnixFSShardingSizeThreshold`. * chore: add dag-jose code to the cid command output * add support for setting automatic unixfs sharding threshold from the config * test: have tests use low cutoff for sharding to mimic old behavior * test: change error message to match the current error * test: Add automatic sharding/unsharding tests (#8547) * test: refactored naming in the sharding sharness tests to make more sense * ci: set interop test executor to convenience image for Go1.16 + Node * ci: use interop master Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Marten Seemann <martenseemann@gmail.com> Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Gus Eggert <gus@gus.dev> Co-authored-by: Lucas Molas <schomatis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't build, as it depends on #8522.
Also depends on ipfs/go-ipfs-config#157.
I didn't want to pile on that PR though, it's already chaotic enough..