fixing bug 812 by BrendanBenshoof · Pull Request #823 · ipfs/kubo

BrendanBenshoof · 2015-02-25T14:25:06Z

hopefully I finally got this right
bug #812

jbenet · 2015-02-25T23:54:28Z

mux.Handle("/"+path+"/", handler)
mux.Handle("/"+path, handler)

not all browsers redirect correctly (curl)

BrendanBenshoof · 2015-02-25T23:58:56Z

We already went through that.
see pull request #816 (closed) #816

jbenet · 2015-02-26T00:19:03Z

Ah, ok! great then.

jbenet · 2015-02-26T00:21:54Z

I think this needs to be in a sharness test to makes sure it doesn't regress.

@BrendanBenshoof take a look at test/sharenss/t0110-gateway.sh -- if you feel comfortable writing one of those great, else I can do it.

BrendanBenshoof · 2015-02-27T22:39:15Z

@jbenet Test is added

BrendanBenshoof · 2015-02-27T23:17:44Z

test/sharness/t0110-gateway.sh

This will need updating whenever a new version of WebUI is pushed

BrendanBenshoof · 2015-02-28T01:30:37Z

I am getting different behavior on my node versus the Travis CI (see #840 ) and I relaxed the test to allow for it.

I currently test:
does node:5001/webui and node:5001/webui/ return either code 302 or 301

I should also test:
does node:5001/ipfs/correcthash return 404 (when lookup fails)
does node:5001/ipfs/wronghash return 403
But I think those test should be part of addressing #840

whyrusleeping · 2015-03-02T21:48:35Z

expected

these files shouldnt be here i dont think

whyrusleeping · 2015-03-02T21:49:03Z

remove weird files in root and LGTM

whyrusleeping · 2015-03-02T21:52:35Z

test/sharness/t0110-gateway.sh

Hrm... now that i think about it, lets work on breaking this up into a few smaller test. do each curl in one, make sure it succeeds, do the text comparisons in their own functions.

👍 on smaller tests

How about 2 tests:
Files actually download and
Codes match expected values

maybe also divide by webui and webui/ (may be easier to read/edit as two semi identical blocks)

jbenet · 2015-03-02T22:16:56Z

test/sharness/t0110-gateway.sh

needs && at end of each line.

BrendanBenshoof · 2015-03-02T23:04:26Z

Ok, I broke into two test that share some state.

jbenet · 2015-03-02T23:08:51Z

LGTM!

fixing bug 812

BrendanBenshoof force-pushed the master branch 2 times, most recently from 93c3e73 to feaf10d Compare February 27, 2015 22:37

BrendanBenshoof force-pushed the master branch from feaf10d to 7fc68c4 Compare February 27, 2015 22:56

BrendanBenshoof mentioned this pull request Feb 27, 2015

Updating the Webui #825

Closed

BrendanBenshoof reviewed Feb 27, 2015
View reviewed changes

test/sharness/t0110-gateway.sh

Copy link
Copy Markdown

Author

BrendanBenshoof Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need updating whenever a new version of WebUI is pushed

BrendanBenshoof mentioned this pull request Feb 28, 2015

IPFS http servers do not respond meaningfully to HEAD requests #840

Closed

BrendanBenshoof force-pushed the master branch from 6181206 to 1416f85 Compare February 28, 2015 02:28

whyrusleeping reviewed Mar 2, 2015
View reviewed changes

expected Outdated

Copy link
Copy Markdown

Member

whyrusleeping Mar 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these files shouldnt be here i dont think

whyrusleeping reviewed Mar 2, 2015
View reviewed changes

fixing bug 812

ac5cfc5

BrendanBenshoof force-pushed the master branch from 1416f85 to ac5cfc5 Compare March 2, 2015 22:08

jbenet reviewed Mar 2, 2015
View reviewed changes

test/sharness/t0110-gateway.sh Outdated

Copy link
Copy Markdown

Member

jbenet Mar 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs && at end of each line.

split the tests

ed17926

BrendanBenshoof force-pushed the master branch from b3af391 to ed17926 Compare March 2, 2015 22:55

jbenet added a commit that referenced this pull request Mar 3, 2015

Merge pull request #823 from BrendanBenshoof/master

9f27556

fixing bug 812

jbenet merged commit 9f27556 into ipfs:master Mar 3, 2015

BrendanBenshoof mentioned this pull request Mar 3, 2015

localhost:5001/webui/ should work too #812

Closed

Uh oh!

Conversation

BrendanBenshoof commented Feb 25, 2015

Uh oh!

jbenet commented Feb 25, 2015

Uh oh!

BrendanBenshoof commented Feb 25, 2015

Uh oh!

jbenet commented Feb 26, 2015

Uh oh!

jbenet commented Feb 26, 2015

Uh oh!

BrendanBenshoof commented Feb 27, 2015

Uh oh!

BrendanBenshoof Feb 27, 2015

Choose a reason for hiding this comment

Uh oh!

BrendanBenshoof commented Feb 28, 2015

Uh oh!

whyrusleeping Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

whyrusleeping commented Mar 2, 2015

Uh oh!

whyrusleeping Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

jbenet Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

BrendanBenshoof Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

jbenet Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

jbenet Mar 2, 2015

Choose a reason for hiding this comment

Uh oh!

BrendanBenshoof commented Mar 2, 2015

Uh oh!

jbenet commented Mar 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants