feat: use the context to thread sessions through all commands#7201
Draft
feat: use the context to thread sessions through all commands#7201
Conversation
9c618ee to
6b02140
Compare
6b02140 to
f6e7809
Compare
dirkmc
reviewed
Apr 23, 2020
* Ensure we have a single session per gateway request. * Use a session in the ipfs refs command. * Start a session before resolving the pin root (also fixes sessions while pinning). * Update go-merkledag to reliably create sessions. part of #7198
f6e7809 to
7374929
Compare
Co-Authored-By: dirkmc <dirkmdev@gmail.com>
Contributor
|
We should probably merge this PR first: Send CANCELs when session context is cancelled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #7198