This repository was archived by the owner on Feb 1, 2023. It is now read-only.
Send CANCELs when session context is cancelled#375
Merged
Stebalien merged 1 commit intorefactor/unref-want-mgrfrom Apr 23, 2020
Merged
Send CANCELs when session context is cancelled#375Stebalien merged 1 commit intorefactor/unref-want-mgrfrom
Stebalien merged 1 commit intorefactor/unref-want-mgrfrom
Conversation
Stebalien
approved these changes
Apr 23, 2020
Member
|
Ah, actually, I didn't realize this was against the refactor branch. Could we make another one against master? I want to sneak this into the release as a bugfix but I'd like to leave the refactor out just in case. |
Contributor
Author
|
Sure I'll make one |
Member
|
Ah, wait, nevermind. It looks like the refactor is really small. |
Contributor
Author
|
Here it is in case you want it: #376 |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…ncels Send CANCELs when session context is cancelled This commit was moved from ipfs/go-bitswap@26fbfbf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the session's context is done, the session sends CANCELs for all pending wants.
However it uses the same (done) context to send the CANCELs, so they never actually get sent.
This PR changes the session to use Bitswap's context to send CANCELs on shutdown.