Conversation
7e38d3c to
665019c
Compare
77270e5 to
c14e85c
Compare
11 tasks
Member
Author
Member
|
Ok, I'm just going to rebase #5526. |
bee0298 to
63116c1
Compare
724f640 to
6571281
Compare
53efd96 to
ab2ac69
Compare
Stebalien
requested changes
Dec 13, 2018
magik6k
commented
Dec 14, 2018
Stebalien
requested changes
Dec 18, 2018
Member
Stebalien
left a comment
There was a problem hiding this comment.
A few minor fixes but this looks good otherwise.
| return nil, 0, err | ||
| } | ||
|
|
||
| if file.IsDirectory() { |
Member
There was a problem hiding this comment.
What'll happen if this is a symlink?
Member
Author
There was a problem hiding this comment.
I don't think we have proper support for them currently anyways. Changed the error to make it less confusing
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Member
Author
|
@Stebalien rebased, is there anything else blocking this or is it RFM? |
Stebalien
approved these changes
Dec 20, 2018
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
Update for go-ipfs-files refactor This commit was moved from ipfs/kubo@daa1202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ipfs/go-ipfs-files#2