Merged
Conversation
Member
|
Diff based on #4802: feat/coreapi/split-iface...feat/coreapi/refactor-opts |
abf4c3c to
8b29773
Compare
4 tasks
Stebalien
approved these changes
Mar 12, 2018
Member
Stebalien
left a comment
There was a problem hiding this comment.
(approving the options refactor part)
I definitely prefer this. Also, nice docs!
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
This was referenced Mar 24, 2018
Merged
Merged
Merged
8b29773 to
79f56c1
Compare
Kubuxu
reviewed
Mar 25, 2018
core/coreapi/pin_test.go
Outdated
| } | ||
|
|
||
| list, err = api.Pin().Ls(ctx, api.Pin().WithType("indirect")) | ||
| list, err = api.Pin().Ls(ctx, opt.Pin.Type("indirect")) |
Member
There was a problem hiding this comment.
Nicer UX would be if we had already defined functions for different pin types. Like opt.Pin.TypeIndirect or opt.Pin.Type.Indirect
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Member
|
See the codeclimate (https://codeclimate.com/github/ipfs/go-ipfs/pull/4807) you can omit the _ in function receiver if it is not used. |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Member
Author
|
Done |
Kubuxu
approved these changes
Mar 26, 2018
Member
|
So, jenkins passed. It looks like something went wrong with the webhook. |
Member
|
nice! This does feel much nicer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #4802
Suggested by @Stebalien and @Kubuxu in #4643 (comment).