coreapi: Split the interface into multiple files#4802
Merged
whyrusleeping merged 5 commits intomasterfrom Mar 23, 2018
Merged
Conversation
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
This was referenced Mar 10, 2018
Merged
Merged
Merged
Kubuxu
reviewed
Mar 10, 2018
core/coreapi/interface/errors.go
Outdated
| import "errors" | ||
|
|
||
| var ErrIsDir = errors.New("object is a directory") | ||
| var ErrOffline = errors.New("can't resolve, ipfs node is offline") |
Member
There was a problem hiding this comment.
nitpick: var block might be cleaner here.
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Stebalien
approved these changes
Mar 12, 2018
Member
Stebalien
left a comment
There was a problem hiding this comment.
Are there any changes here other than simply documenting and splitting things up into multiple files? Diffs make hard to to tell. If not, LGTM (although I didn't read the diff thoroughly).
Member
Author
|
The only API change other than splitting the interface into multiple files is the removal of mirrored |
Kubuxu
approved these changes
Mar 12, 2018
whyrusleeping
approved these changes
Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface file has become quite crowed now, splitting it helps a lot.