Replace #3990: blocks: move block format to it's own repo#4023
Merged
whyrusleeping merged 4 commits intomasterfrom Jul 3, 2017
Merged
Replace #3990: blocks: move block format to it's own repo#4023whyrusleeping merged 4 commits intomasterfrom
whyrusleeping merged 4 commits intomasterfrom
Conversation
We need to reference it from outside of this repo. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
And updated related dependencies. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
For some reason, this was referenced but wasn't listed in packages.json. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Member
|
Did I miss something? This PR is identical to #3990... |
Member
|
@Stebalien yeah, #3990 was on your repo (and not the main go-ipfs one) so we couldnt rebase it on our own. This is just your commits rebased on latest master, we didnt want to bother you asking for a rebase :) |
Member
|
Ah. Got it. Thanks :).
…On June 29, 2017 1:43:02 PM PDT, Jeromy Johnson ***@***.***> wrote:
@Stebalien yeah, #3990 was on your repo (and not the main go-ipfs one)
so we couldnt rebase it on our own. This is just your commits rebased
on latest master, we didnt want to bother you asking for a rebase :)
|
Member
|
Waiting on ipfs/go-ipld-cbor#16 |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
Member
|
The current test failure looks unrelated: test/sharness/t0130-multinode.sh: |
Member
|
Yes it is one of unrelated failures we are chasing for a long time. |
Member
|
LGTM! |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
Replace #3990: blocks: move block format to it's own repo This commit was moved from ipfs/kubo@7488102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #3990