Hotfix: return parsed options if argument parsing failed#378
Merged
jbenet merged 1 commit intoipfs:masterfrom Nov 23, 2014
Merged
Hotfix: return parsed options if argument parsing failed#378jbenet merged 1 commit intoipfs:masterfrom
jbenet merged 1 commit intoipfs:masterfrom
Conversation
This was referenced Nov 23, 2014
Member
|
@dborzov good find! LGTM |
jbenet
added a commit
that referenced
this pull request
Nov 23, 2014
Hotfix: return parsed options if argument parsing failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #373.
The reason it was failing is that Parse() func even when
reqinstance was intialized correctly it was not returned if there was an argument parsing exception.Request.optionscontains mention of--helpflag (withinrequest.optionsasmap[string]string{help:"",}) that is used to check if the help option was called.