Conversation
This reverts commit 36c29c5.
fc3efd4 to
646174b
Compare
646174b to
7c269ad
Compare
aschmahmann
commented
Feb 27, 2026
Comment on lines
+339
to
+343
| #### 🐹 Go 1.26 | ||
|
|
||
| This release is built with [Go 1.26](https://go.dev/doc/go1.26). | ||
|
|
||
| You should see lower memory usage and reduced GC pauses thanks to the new Green Tea garbage collector (10-40% less GC overhead). Reading block data and API responses is faster due to `io.ReadAll` improvements (~2x faster, ~50% less memory). On 64-bit platforms, heap base address randomization adds a layer of security hardening. |
Contributor
Author
There was a problem hiding this comment.
We should remove this and the ToC entry for it since we're switching back to 1.25 until bugs are fixed (or add an addendum about Windows specific downgrading) , right?
c3b83ed to
0104e32
Compare
- config/autoconf.go: restore math/rand/v2 (available since go 1.22) - core/corehttp/p2p_proxy.go: restore httputil.ReverseProxy.Rewrite (available since go 1.21) - core/commands/name/name.go: restore %d format for ValidityType int64 - docs/changelogs/v0.40.md: keep shipped v0.40.0 notes intact, add v0.40.1 section
0104e32 to
5372ecb
Compare
lidel
added a commit
that referenced
this pull request
Feb 27, 2026
* Revert "feat: update to Go 1.26 (#11189)" This reverts commit 36c29c5. * chore: go mod tidy * fix: keep go 1.25-compatible modernizations, add v0.40.1 changelog - config/autoconf.go: restore math/rand/v2 (available since go 1.22) - core/corehttp/p2p_proxy.go: restore httputil.ReverseProxy.Rewrite (available since go 1.21) - core/commands/name/name.go: restore %d format for ValidityType int64 - docs/changelogs/v0.40.md: keep shipped v0.40.0 notes intact, add v0.40.1 section --------- Co-authored-by: Marcin Rataj <lidel@lidel.org> (cherry picked from commit 550d3b6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 36c29c5.
Allows us to downgrade Go in order to handle what seem to be Go 1.26.0 issues on Windows associated with #11214