feat(util:context) add error logging to context#108
Merged
Conversation
Contributor
Author
|
I held off on adding... One concern with this is that it leaks the implementation of the error logging. If the parent context was created using |
Member
|
@perfmode yep, good point. i guess this is why |
This commit... is a second attempt at: #68 partially addresses: #66 is the result of discussion at: https://gist.github.com/perfmode/f2951c1ed3a02c484d0b
Contributor
Author
Member
|
Other than an impressively long test name, LGTM |
Member
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
handle paths as DHT keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@jbenet
@whyrusleeping
This commit...
is a second attempt at: #68
partially addresses: #66
is the result of discussion at: https://gist.github.com/perfmode/f2951c1ed3a02c484d0b