Conversation
4 tasks
Jorropo
reviewed
Nov 8, 2023
Contributor
Jorropo
left a comment
There was a problem hiding this comment.
Is there zero tests which can catch this ?
I'm having a hard time we let something like that slide.
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Nov 8, 2023
ipfs.dns is deprecated, and broken in Kubo 0.24: ipfs/kubo#10212
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Nov 8, 2023
ipfs.dns is deprecated, and broken in Kubo 0.24: ipfs/kubo#10212
this command used to work with domain without `/ipns/` prefix. we've switched it to the same backend as `resolve` command, which requires the prefix, so we add it if it is missing
2effc26 to
067b3e3
Compare
Member
It seems so. This command has been deprecated for over 1 year and a half. The fact that no one complained or we didn't see things failing also shows that it's likely not used. Wouldn't be surprised if we end up removing it in some months. This command is also very hard to test! It uses DNS resolver directly and you can't override resolution via environment variables. |
hacdias
approved these changes
Nov 9, 2023
lidel
added a commit
to ipfs/ipfs-companion
that referenced
this pull request
Jan 24, 2024
ipfs.dns is deprecated, and broken in Kubo 0.24: ipfs/kubo#10212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems we've introduced regression to the deprecated
dnscommand, it now requires/ipns/path, which breaks every software which used it for DNSLink lookups.It was already deprecated, so no need for patch release, but let's fix it and improve helptext that is displayed at https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-dns when the next release ships.
before
expected behavior (this fix)