Conversation
5 tasks
daviddias
reviewed
Oct 3, 2016
| message Metadata { | ||
| required string MimeType = 1; | ||
| } | ||
| `) |
Member
There was a problem hiding this comment.
AFAIK, the protobuf module actually takes up a string. If we are going to move this forward, better return a string than a Buffer
Member
Author
There was a problem hiding this comment.
Sure I don't mind, going to check the source to see what it needs
Member
Author
There was a problem hiding this comment.
Let's move to a string, it gets converted directly to a string anyway in the module https://github.com/mafintosh/protocol-buffers-schema/blob/master/parse.js#L529
Using string instead of buffer for proto file
achingbrain
added a commit
that referenced
this pull request
Feb 19, 2020
chore: remove redundant test files
achingbrain
added a commit
that referenced
this pull request
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.