Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

feat: support remote pinning services in ipfs-http-client#3293

Merged
Gozala merged 57 commits intomasterfrom
feat/pin-remote
Jan 30, 2021
Merged

feat: support remote pinning services in ipfs-http-client#3293
Gozala merged 57 commits intomasterfrom
feat/pin-remote

Conversation

@lidel
Copy link
Member

@lidel lidel commented Sep 18, 2020 •
edited by Gozala
Loading

Part of ipfs/kubo#7559

This adds basic boilerplate for supporting remote pinning commands from ipfs/kubo#7661 in js-ipfs-http-client

TODO

Refs

Requires: ipfs/kubo#7661
cc: ipfs/ipfs-gui#91, ipfs/ipfs-webui#1615, @jessicaschilling, @rafaelramalho19, @achingbrain, @jacobheun

@lidel
wip: pin.remote.add|ls|rm
caf935f 
This adds basic boilerplate for supporting remote pinning commands
introduced in ipfs/kubo#7661

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel
Copy link
Member Author

lidel commented Sep 18, 2020 •
edited
Loading

@achingbrain is it possible to add generic tests to interface-ipfs-core but limit implementation to http client for now?
(I think I've seen a way for suppressing tests in js-ipfs)

@achingbrain
Copy link
Member

achingbrain commented Sep 21, 2020

is it possible to add generic tests to interface-ipfs-core but limit implementation to http client for now

Yes - add the tests to the suite as normal and skip them in /packages/ipfs/test/core/interface.spec.js and /packages/ipfs/test/http-api/interface.js

@aschmahmann aschmahmann mentioned this pull request Sep 30, 2020
Closed
73 tasks
@lidel lidel mentioned this pull request Oct 6, 2020
Merged
@lidel
Copy link
Member Author

lidel commented Nov 3, 2020

@Gozala mind taking over and pushing this over finish line when you have time?

@jacobheun
Copy link
Contributor

jacobheun commented Nov 4, 2020

@lidel, @hugomrdias might pick up the rest of the pinning service work so he might be able to take this over if @Gozala is full up.

@lidel lidel assigned hugomrdias and unassigned Gozala Nov 10, 2020
@lidel
Copy link
Member Author

lidel commented Nov 10, 2020 •
edited
Loading

Handing over to @hugomrdias @Gozala 🤝

@Gozala Gozala self-assigned this Nov 16, 2020
@Gozala Gozala mentioned this pull request Dec 4, 2020
Closed
lidel
lidel commented Dec 7, 2020
View reviewed changes
@hugomrdias hugomrdias removed their assignment Dec 9, 2020
@lidel
Copy link
Member Author

lidel commented Dec 9, 2020

@Gozala fYSA go-ipfs 0.8.0-rc1 just shipped, you can switch tests to run against https://www.npmjs.com/package/go-ipfs/v/0.8.0-rc1

js-ipfs/packages/ipfs-http-client/package.json

Line 83 in 4d54a7c

"go-ipfs": "^0.7.0",

@Gozala
Copy link
Contributor

Gozala commented Dec 11, 2020

Errors on CI are related to #3442

@lidel
Copy link
Member Author

lidel commented Jan 19, 2021

@Gozala also, had trouble with building unless I bumped "ipfs-core-types" to "^0.2.0" – mind rebasing this PR?

@Gozala Gozala requested a review from hugomrdias January 19, 2021 18:45
@Gozala
Copy link
Contributor

Gozala commented Jan 20, 2021

For some reason when testing in browser node process just won't exit. It must be due to https://github.com/ipfs/js-ipfs/pull/3293/files#diff-bd8c36bcaf63bb93ceec2bb8a8a7d261692b8e416c10eed90d3e03232bc3873e but I just can't seem to figure out why.

@rafaelramalho19 rafaelramalho19 mentioned this pull request Jan 21, 2021
Merged
achingbrain
achingbrain approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to sort the merge conflicts out

@lidel lidel mentioned this pull request Jan 27, 2021
Closed
@lidel
Copy link
Member Author

lidel commented Jan 29, 2021

@Gozala FYI I've just bumped this PR to use go-ipfs 0.8.0-rc2 so we identify issues early (if any)

@Gozala Gozala removed the request for review from hugomrdias January 29, 2021 22:38
@Gozala Gozala merged commit ba240fd into master Jan 30, 2021
@Gozala Gozala deleted the feat/pin-remote branch January 30, 2021 02:16
This was referenced Mar 11, 2021
Closed
Closed
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
@lidel
feat: support remote pinning services in ipfs-http-client (#3293)
1e874c2 
Implement [remote pinning service API](https://github.com/ipfs/pinning-services-api-spec) in ipfs-http-client.
@snyk-bot snyk-bot mentioned this pull request Sep 21, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@achingbrain achingbrain achingbrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Gozala Gozala

Labels

None yet

Projects

No open projects
JS IP Board (deprecated)
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lidel @achingbrain @jacobheun @Gozala @hugomrdias