Conversation
Contributor
|
Some of these are caused by migrating i18n keys -- happy to jump on a quick call and resolve together. LMK. |
This was referenced Sep 18, 2020
Closed
c5640dd to
7601bd5
Compare
884b165 to
d28b8ac
Compare
Contributor
|
@rafaelramalho19 What's the latest with this? |
Contributor
This will be a long lasting PR, since it's the epic that will contain all features. Currently we're splitting all work done into separate PRs to become easier to review |
3 tasks
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
* chore: refactor files page * feat: add pinning services mock to files page * chore: update remotePin dimensions Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update local pin icon dimension Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: change pin icon fill color Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: change remote pin icon fill color Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal text size Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal text size Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: pinning modal secondary text changes Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal image size Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal pin icon Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: add pin status column to fileslist * chore: fix modals icons * chore: fix linting error * chore: fix files sorting Co-authored-by: Jessica Schilling <jessica@protocol.ai>
bc60e46 to
de44936
Compare
Member
Author
|
Continued in #1685 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit 27 October: Current plan is to merge this into master sooner rather than later to not block other work — this will require detecting pinning service support (#1680) and removing/amending UI elements in cases where it isn't present.
cc @jessicaschilling @rafaelramalho19
Closes #1404 (UI for raw pins removed)
Closes #1403 (UI for raw pins removed)