Feat/pinning settings custom modal#1546
Merged
rafaelramalho19 merged 6 commits intoepic/pinning-servicesfrom Jul 17, 2020
Merged
Feat/pinning settings custom modal#1546rafaelramalho19 merged 6 commits intoepic/pinning-servicesfrom
rafaelramalho19 merged 6 commits intoepic/pinning-servicesfrom
Conversation
a1b001a to
acd1be9
Compare
lidel
approved these changes
Jul 15, 2020
Member
lidel
left a comment
There was a problem hiding this comment.
lgtm, but would like @jessicaschilling to go over newly added labels
jessicaschilling
suggested changes
Jul 16, 2020
Contributor
jessicaschilling
left a comment
There was a problem hiding this comment.
LGTM, just some tiny text nits 😊
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
rafaelramalho19
added a commit
that referenced
this pull request
Sep 29, 2020
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
rafaelramalho19
added a commit
that referenced
this pull request
Oct 6, 2020
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
rafaelramalho19
added a commit
that referenced
this pull request
Nov 3, 2020
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
rafaelramalho19
added a commit
that referenced
this pull request
Nov 10, 2020
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
rafaelramalho19
added a commit
that referenced
this pull request
Dec 14, 2020
* Feat/pinning settings (#1535) * Feat/pinning settings custom modal (#1546) Co-authored-by: Jessica Schilling <jessica@protocol.ai> * Feat/redesign files bar (#1513) * Feat/pinning settings (#1535) (#1557) * feat: add pinning services service modal * chore: update translation for service modal * chore: fix tslint in directory selector * chore: fix tscheck issues in upper directory selector * chore: fix tslint in selectors * feat: add pinning to files page (#1678) * chore: refactor files page * feat: add pinning services mock to files page * chore: update remotePin dimensions Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update local pin icon dimension Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: change pin icon fill color Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: change remote pin icon fill color Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal text size Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal text size Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: pinning modal secondary text changes Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal image size Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update pinning modal pin icon Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: add pin status column to fileslist * chore: fix modals icons * chore: fix linting error * chore: fix files sorting Co-authored-by: Jessica Schilling <jessica@protocol.ai> * feat: prepare pinning services for stage 1 * chore: remove remote pins from settings page for stage 1 * chore: update pinning manager padding Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update modal horizontal padding Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: make settings page pinning table responsive * chore: update settings page description in pinning table * chore: update header style Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update settings page in smaller viewports * chore: remove outline on pinning tables focus * chore: update translation Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: update translation Co-authored-by: Jessica Schilling <jessica@protocol.ai> * chore: add titles to bar options * chore: add titles to bar options * Update public/locales/en/files.json * feat: add pins size to the settings page * feat: add number of pins to settings page * chore: feat tslint * chore: fix error in button * test(e2e): more reliable api test suite This changes the way we enter API address/config from programmatic to full simulation of user input and adds tiny slow down between each key stroke. This should solve the problem of newly added UI feedback not engaging, and make CI both more reliable and green again. While at it, made it CI-agnostic, in preparation for move to GithubActions Co-authored-by: Jessica Schilling <jessica@protocol.ai> Co-authored-by: Marcin Rataj <lidel@lidel.org>
rafaelramalho19
added a commit
that referenced
this pull request
Dec 14, 2020
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing action for saving the integration (will be done when we have a working API)
Questions: